Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add command to scan external storages directly #25109

Merged
merged 1 commit into from
Mar 7, 2024
Merged

add command to scan external storages directly #25109

merged 1 commit into from
Mar 7, 2024

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jan 13, 2021 •
edited
Loading

the main use case of this over simply scanning through the full path is the ability to provide a username and/or password for cases where login credentials are used and remove the need to pick a user to scan through

Signed-off-by: Robin Appelman [email protected]

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 13, 2021
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone Jan 13, 2021
@MorrisJobke
Copy link
Member

CS and Psalm have complains

@rullzer
Copy link
Member

rullzer commented Jan 27, 2021

Ping @icewind1991 I think it would be good to have this in a good shape for when we branch off

@rullzer
Copy link
Member

rullzer commented Mar 30, 2021

Sooo.... continue or close?

@MorrisJobke MorrisJobke mentioned this pull request May 20, 2021
Merged
@MorrisJobke
Copy link
Member

Sooo.... continue or close?

🏓

@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
Merged
98 tasks
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@blizzz
Copy link
Member

blizzz commented Jun 2, 2021

conflicts and unhappy CI

@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
Merged
59 tasks
This was referenced Jun 16, 2021
Merged
Merged
@blizzz
Copy link
Member

blizzz commented Jun 23, 2021

moving to 23

@blizzz blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 23, 2021
@MorrisJobke MorrisJobke removed their request for review July 4, 2021 11:31
@skjnldsv
Copy link
Member

/rebase

@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 22, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
This was referenced Apr 7, 2022
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Merged
@blizzz blizzz added this to the Nextcloud 28 milestone May 23, 2023
come-nc
come-nc approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cleaner to also support json output since if I recall correctly all occ command advertise support for --output=json

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv
Copy link
Member

@icewind1991 or @come-nc can you rebase?

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 27, 2024
@skjnldsv skjnldsv removed the request for review from rullzer February 27, 2024 13:22
@icewind1991 icewind1991 force-pushed the external-scan branch 2 times, most recently from 4208014 to d7d8822 Compare March 6, 2024 16:35
@icewind1991
feat: add command to scan external storages directly
42e14cc 
the main use case of this over simply scanning through is the ability to provide a username and/or password for cases where login credentials are used

Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 7, 2024
@icewind1991 icewind1991 merged commit 5d2198b into master Mar 7, 2024
160 checks passed
@icewind1991 icewind1991 deleted the external-scan branch March 7, 2024 10:11
@emoral435 emoral435 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 7, 2024
@blizzz blizzz mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge is a code owner

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
8 participants
@icewind1991 @MorrisJobke @rullzer @blizzz @skjnldsv @come-nc @PVince81 @emoral435