Properly handle folder deletion on external s3 storage #24185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
rullzer,
MorrisJobke,
icewind1991,
ChristophWurst and
kesselb
Merged
|
cc @icewind1991 |
juliusknorr
requested review from
skjnldsv
and removed request for
rullzer and
MorrisJobke
juliusknorr
force-pushed
the
bugfix/noid/external-s3-delete-folder
branch
from
7129f2c
to
213bf2b
Compare
skjnldsv
approved these changes
Jun 23, 2021
|
/rebase |
Signed-off-by: Julius Härtl <[email protected]>
…m another storage Signed-off-by: Julius Härtl <[email protected]>
nextcloud-command
force-pushed
the
bugfix/noid/external-s3-delete-folder
branch
from
213bf2b
to
bc3c463
Compare
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
|
hmmm, I hoped this would fix nextcloud/files_versions_s3#11 but it doesn't. I'll investigate, also need to make sure that nested subdirs would get deleted too. |
This was referenced Oct 11, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Fixed by 7129f2c since otherwise the copyFromStorage would return false which is wrong for an empty directory
Fixed by 62c0009 which makes sure that any leftover of the path is removed from the bucket.
I remember also seeing an issue for that but I cannot find it anymore.