Execute MoveAvatars repair step only once #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @nickvergessen and @icewind1991 to be potential reviewers. |
| @@ -33,32 +34,40 @@ class MoveAvatars implements IRepairStep { | |||
| private $jobList; | |||
|
|
|||
| /** @var SystemConfig */ | |||
| @@ -24,6 +24,7 @@ | |||
|
|
|||
| use OC\SystemConfig; | |||
|
what @nickvergessen said, otherwise looks good |
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
add-avatar-job-once
branch
from
91979cd
to
69db582
Compare
|
@nickvergessen @blizzz Done :) |
Current coverage is 56.96% (diff: 0.00%)
|
|
So this still runs on the first update, when you install 11, sounds odd... |
|
@nickvergessen Why odd? Repair steps need to be executed ;) |
|
But also on an instance that does not need fixing? |
|
Well since its getting better with this, fine by me 👍 |
|
Lets do this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rullzer @nickvergessen @LukasReschke @schiessle @blizzz