-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move encryption from app.php to IBootstrap #24036
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MorrisJobke
commented
Nov 10, 2020
•
edited
Loading
edited
- depends on [encryption] Remove dependency fetching inside the constructor and mo… #24289
MorrisJobke
requested review from
rullzer,
nickvergessen,
ChristophWurst,
juliusknorr,
kesselb and
skjnldsv
November 10, 2020 20:00
MorrisJobke
force-pushed
the
techdebt/noid/encryption-ibootstrap
branch
from
November 10, 2020 20:20
420a3c3
to
4cae8fa
Compare
skjnldsv
approved these changes
Nov 12, 2020
MorrisJobke
force-pushed
the
techdebt/noid/encryption-ibootstrap
branch
from
November 22, 2020 22:01
8cb534a
to
0ea5614
Compare
MorrisJobke
changed the base branch from
master
to
techdebt/noid/encryption-make-application-class-dependency-free
November 22, 2020 22:02
MorrisJobke
changed the base branch from
techdebt/noid/encryption-make-application-class-dependency-free
to
master
November 22, 2020 22:20
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 35822: failuresqliteShow full log
mariadb10.1-php7.3Show full log
mariadb10.4-php7.4Show full log
mysql8.0-php7.4Show full log
mysql5.6-php7.3Show full log
postgres9-php7.3Show full log
postgres11-php7.4Show full log
acceptance-app-files-sharing
Show full log
|
MorrisJobke
force-pushed
the
techdebt/noid/encryption-ibootstrap
branch
from
November 23, 2020 15:24
81575e0
to
1e89772
Compare
ChristophWurst
approved these changes
Nov 23, 2020
please solve the conflicts |
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
techdebt/noid/encryption-ibootstrap
branch
from
March 17, 2021 13:32
1e89772
to
3a16762
Compare
Done - was only in the license header of the deleted file. |
ChristophWurst
added
the
4. to release
Ready to be released and/or waiting for tests to finish
label
Mar 17, 2021
MorrisJobke
added
2. developing
Work in progress
and removed
4. to release
Ready to be released and/or waiting for tests to finish
labels
Mar 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.