Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to @nextcloud/webpack-vue-config #23973

Closed
wants to merge 3 commits into from
Closed

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 7, 2020

@skjnldsv skjnldsv added this to the Nextcloud 21 milestone Nov 7, 2020
@skjnldsv skjnldsv force-pushed the feat/webpack-vue-config branch 4 times, most recently from 0fbafa8 to b7a485a Compare November 7, 2020 14:41
@skjnldsv skjnldsv marked this pull request as ready for review November 7, 2020 15:00
@skjnldsv skjnldsv added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels Nov 7, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 7, 2020

Aaaaw dang it!
We need mochapack compatibility with webpack 5 sysgears/mochapack#83...
@ChristophWurst we only run one test there 🙈

I'm having trouble understanding what is this about:

module.exports = merge(common[0], {

We take the first module to test? The first module is accessibility, but we test core?
I'm confused 🤔

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 7, 2020

@MorrisJobke @rullzer, what shall I do ?
ERROR: Please remove or add those files again or inform the release team about those now files to be included or excluded from the release tar ball: stylelint.config.js

@faily-bot

This comment has been minimized.

@ChristophWurst ChristophWurst removed their request for review November 9, 2020 08:18
@MorrisJobke

This comment has been minimized.

@MorrisJobke

This comment has been minimized.

@rullzer rullzer mentioned this pull request Dec 14, 2020
59 tasks
@skjnldsv skjnldsv removed this from the Nextcloud 21 milestone Dec 14, 2020
@skjnldsv skjnldsv added this to the Nextcloud 22 milestone Dec 14, 2020
@rullzer
Copy link
Member

rullzer commented Mar 22, 2021

What is the state here?

@skjnldsv
Copy link
Member Author

We need mochapack compatibility with webpack 5 sysgears/mochapack#83...

@skjnldsv
Copy link
Member Author

Rebased

@skjnldsv skjnldsv force-pushed the feat/webpack-vue-config branch 2 times, most recently from faab3e9 to 5d79771 Compare March 23, 2021 14:46
@skjnldsv
Copy link
Member Author

I think I found a way :O

@rullzer
Copy link
Member

rullzer commented Mar 23, 2021

image

@skjnldsv
Copy link
Member Author

I think I found a way :O

Now everything else is failing! 😠

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 9, 2021

Checker need a bump


ERROR: There were 3 additional files:
--
123 | .mocharc.yml
124 | stylelint.config.js
125 | webpack.js
126 | ERROR: There were 3 missing files:
127 | webpack.common.js
128 | webpack.dev.js
129 | webpack.prod.js
130 | ERROR: Please remove or add those files again or inform the release team about those now files to be included or excluded from the release tar ball.

This was referenced May 20, 2021
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 22, Nextcloud 23 Jun 2, 2021
@skjnldsv
Copy link
Member Author

/rebase

@skjnldsv skjnldsv closed this Jul 22, 2021
@skjnldsv
Copy link
Member Author

Let's do it step by step
#28115

Changing the babel config seems to cause issues with the OC/globals exports

@skjnldsv skjnldsv deleted the feat/webpack-vue-config branch October 19, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants