-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move preview provider registration to bootstrap #23171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Merged
skjnldsv
force-pushed
the
enh/preview/move_to_bootstrap
branch
from
October 13, 2021 10:04
73c0219
to
f4de951
Compare
Rebased and adapted |
skjnldsv
requested review from
ChristophWurst,
a team,
PVince81,
ArtificialOwl,
come-nc,
nickvergessen and
blizzz
and removed request for
a team
October 13, 2021 10:05
skjnldsv
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Oct 13, 2021
Psalm's preaching. |
I preached back. |
ChristophWurst
force-pushed
the
enh/preview/move_to_bootstrap
branch
from
October 13, 2021 17:36
25ed695
to
a1c46bc
Compare
skjnldsv
approved these changes
Oct 15, 2021
skjnldsv
force-pushed
the
enh/preview/move_to_bootstrap
branch
from
October 15, 2021 13:08
34d6303
to
1f7568a
Compare
blizzz
reviewed
Oct 20, 2021
Signed-off-by: Roeland Jago Douma <[email protected]> Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
enh/preview/move_to_bootstrap
branch
from
October 21, 2021 08:35
1f7568a
to
8bc25e3
Compare
blizzz
approved these changes
Oct 21, 2021
@skjnldsv 23 or 24? |
Pytal
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.