-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ellipsized unified search results visible on hover #22420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
1. to develop
Accepted and waiting to be taken care of
feature: search
feature: accessibility
labels
Aug 25, 2020
Can we also highlight the subline and ellipsis on the context of the search term? |
skjnldsv
approved these changes
Aug 25, 2020
skjnldsv
added
3. to review
Waiting for reviews
and removed
1. to develop
Accepted and waiting to be taken care of
labels
Aug 25, 2020
|
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/unified-search-ellipsized-title-subline
branch
from
August 26, 2020 18:30
0db675f
to
06f8c54
Compare
rullzer
approved these changes
Aug 26, 2020
rullzer
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Aug 26, 2020
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32359: failureacceptance-app-files
Show full log
|
nickvergessen
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
bug
feature: accessibility
feature: search
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with results like