Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 excludes the arguments from stack traces by default. #20749

Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Apr 30, 2020

That leads to a false positive is not setup via query() but directly warning for every app because
the check does not work anymore.

Runs only if debug => true.
ini_set seems to ignore non existing $vars: https://3v4l.org/DP4Lg

@kesselb kesselb added bug 3. to review Waiting for reviews labels Apr 30, 2020
@kesselb kesselb added this to the Nextcloud 19 milestone Apr 30, 2020
@rullzer rullzer mentioned this pull request Apr 30, 2020
11 tasks
@kesselb kesselb force-pushed the bug/noid/is-not-setup-via-query-false-positive branch from 434c5ba to e1d48f8 Compare April 30, 2020 14:33
That leads to a false positive is not setup via query() but directly warning for every app because
the check does not work anymore.

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the bug/noid/is-not-setup-via-query-false-positive branch from e1d48f8 to cba7219 Compare April 30, 2020 15:02
Signed-off-by: Daniel Kesselberg <[email protected]>
@rullzer rullzer mentioned this pull request Apr 30, 2020
2 tasks
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nickvergessen nickvergessen merged commit afc5966 into master May 4, 2020
@nickvergessen nickvergessen deleted the bug/noid/is-not-setup-via-query-false-positive branch May 4, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants