-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define getSystemValueBool/Int/String function default parameter with correct type #20717
Conversation
…correct type Signed-off-by: MichaIng <[email protected]>
Do we want to backport this? Just checked and it can be applied at least until back to NC16. On the other hand it does not fix any issues. |
I usually like to keep backports at minimum. Esp in this case the typing already is correct. |
Just for completeness, the new types now also match the public IConfig interface defined here: Lines 79 to 107 in 10a98f9
What you mean with "correct"? However, I agree to skip the backports in this case. |
|
Ah okay yes that was what I was assuming since the "wrong" annotation obviously does/did not cause any issue. So indeed this is of a visual-only kind that popped up to me when looking into the code for another reason 😉. Hence no real reason to backport. |
I guess it does only have minor effect, but at least for consistency the param type should match the actual type defined in the functions.