Add folder argument to files:scan-app-data #20626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you need to rescan something but don't feel like rescanning your whole preview stash. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
requested review from
MorrisJobke,
icewind1991,
ChristophWurst,
juliusknorr and
kesselb
|
-1 for your backlog ;) |
kesselb
reviewed
Apr 24, 2020
| @@ -67,6 +68,8 @@ protected function configure() { | |||
| $this | |||
| ->setName('files:scan-app-data') | |||
| ->setDescription('rescan the AppData folder'); | |||
There was a problem hiding this comment.
Suggested change
| ->setDescription('rescan the AppData folder'); | |
| ->setDescription('rescan the AppData folder') | |
| ->addArgument('folder', InputArgument::OPTIONAL, 'The appdata subfolder to scan', ''); |
ChristophWurst
approved these changes
Apr 24, 2020
|
LGTM 👍 I have some small suggestion while you're at it ;)
|
|
@kesselb mind to tackle them or file an issue? It is not really high on my priority list at the moment |
|
A question on this topic:
That sounds like based on this PR you are now able to exclude the preview folder while scanning the whole app-data folder. Is that the case or do I have to scan all other subfolders manually to be able to exclude the preview folder? |
|
The latter. There is no exclusion just selection of which folder to scan. |
|
Ok, thanks for the answer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12327
If you need to rescan something but don't feel like rescanning your
whole preview stash.
Signed-off-by: Roeland Jago Douma [email protected]