Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] Fix Sharing recommendation user display #20596

Merged
merged 1 commit into from
Apr 23, 2020
Merged

[stable18] Fix Sharing recommendation user display #20596

merged 1 commit into from
Apr 23, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Apr 22, 2020 •
edited
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #20575

@backportbot-nextcloud backportbot-nextcloud bot added bug feature: file sidebar Related to the file sidebar component feature: sharing labels Apr 22, 2020
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.4 milestone Apr 22, 2020
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 22, 2020
Merged
2 tasks
skjnldsv
skjnldsv approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/compile amend /

@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Apr 22, 2020
@skjnldsv @npmbuildbot
Fix Sharing recommendation user display
b990b01 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
MorrisJobke
MorrisJobke approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 62bfd9d into stable18 Apr 23, 2020
@MorrisJobke MorrisJobke deleted the backport/20575/stable18 branch April 23, 2020 12:36
@rullzer rullzer mentioned this pull request May 21, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@danxuliu danxuliu Awaiting requested review from danxuliu

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@rullzer rullzer Awaiting requested review from rullzer

@schiessle schiessle Awaiting requested review from schiessle

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: file sidebar Related to the file sidebar component feature: sharing
Projects
None yet
Milestone
Nextcloud 18.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @MorrisJobke @rullzer