Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying a default expiration date #20587

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Allow specifying a default expiration date #20587

merged 1 commit into from
Apr 24, 2020

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Apr 21, 2020

This overrides the max expiration date.

Signed-off-by: Roeland Jago Douma [email protected]

@rullzer rullzer added this to the Nextcloud 19 milestone Apr 21, 2020
@rullzer rullzer force-pushed the enh/allow_default_expiration_date branch from 2bab841 to 0fb2d10 Compare April 21, 2020 12:17
nickvergessen
nickvergessen reviewed Apr 21, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-|

tests/lib/Share20/ManagerTest.php Outdated Show resolved Hide resolved
@rullzer rullzer force-pushed the enh/allow_default_expiration_date branch from 0fb2d10 to 809914b Compare April 21, 2020 12:22
This was referenced Apr 21, 2020
Merged
Merged
@rullzer rullzer added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 24, 2020
@rullzer
Allow specifying a default expiration date
f4b8623 
This overrides the max expiration date.

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer force-pushed the enh/allow_default_expiration_date branch from 809914b to f4b8623 Compare April 24, 2020 14:18
@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 24, 2020
@rullzer
Copy link
Member Author

rullzer commented Apr 24, 2020

READY FOR REVIEW

@georgehrke georgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 24, 2020
@rullzer rullzer merged commit 652639b into master Apr 24, 2020
@rullzer rullzer deleted the enh/allow_default_expiration_date branch April 24, 2020 15:08
@rullzer
Copy link
Member Author

rullzer commented Apr 24, 2020

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 24, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #20635 with conflicts ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@georgehrke georgehrke georgehrke approved these changes

@schiessle schiessle Awaiting requested review from schiessle

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: sharing
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
4 participants
@rullzer @nickvergessen @georgehrke @ChristophWurst