Workaround for disappearing app icons for Firefox before version 51

[juliusknorr]

Fix for #2005

Please review and test @Luticus @nickvergessen

[mention-bot]

@juliushaertl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @LukasReschke and @MorrisJobke to be potential reviewers.

[MorrisJobke]

For me this still happens if I open the menu before the file list is completely loaded. Once the filelist appears the icons disappear. Maybe there is an interference between the loading of the file list and the app menu.

https://cloud.morrisjobke.de/s/foMi2BUi61dTdLR

• after the first refresh: I wait until everything is loaded and then open the menu ✅
• after the second refresh: I open the menu before the file list is loaded ❌

[nickvergessen]

I guess this means we need to move it outside of the if?

[juliusknorr]

@MorrisJobke @nickvergessen Right, replaceState is also affected. 🙈

Fixed and pushed.

[codecov-io]

Current coverage is 57.80% (diff: 100%)

Merging #2018 into master will increase coverage by 0.01%

@@             master      #2018   diff @@
==========================================
  Files          1094       1094          
  Lines         62793      62936   +143   
  Methods        6994       7043    +49   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          36289      36381    +92   
- Misses        26504      26555    +51   
  Partials          0          0          

Powered by Codecov. Last update f42d5b6...71275ce

[Mannshoch]

This Pach work for me.

Firefox: 49.0.2
Apps: AppOrder and DirectMenu

Thanks a lot!

[MorrisJobke]

Tested and works 👍

Code looks also good

[MorrisJobke]

Even works in IE and Edge without issues.

Counting #2018 (comment) as 👍 -> merge

[MorrisJobke]

@karlitschek This should get backported.

@juliushaertl Could you create the backport PR for stable10? Thanks

[karlitschek]

please backport

[juliusknorr]

backport at #2025

[Mannshoch]

Uh.. strange side effect. Since I add this line of codes i'm not anymore able to open any directory in Owncloud. If I remove it, it works again.

[MorrisJobke]

Uh.. strange side effect. Since I add this line of codes i'm not anymore able to open any directory in Owncloud. If I remove it, it works again.

Thanks for this - I can reproduce this. But this only happens in Firefox - in Chrome everything works

[MorrisJobke]

Thanks for this - I can reproduce this. But this only happens in Firefox - in Chrome everything works

#2033