Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hub bundle for easy installation on upgraded instances #19105

Merged
merged 1 commit into from
Jan 27, 2020
Merged

add hub bundle for easy installation on upgraded instances #19105

merged 1 commit into from
Jan 27, 2020

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 23, 2020

Tada:

Screenshot_20200123_210802

Q: Why are there so few?
A: #19104

Included are all that are being offered in the installation assistant on Nextcloud Hub when doing a fresh install.

@blizzz blizzz added enhancement 3. to review Waiting for reviews labels Jan 23, 2020
@blizzz blizzz added this to the Nextcloud 19 milestone Jan 23, 2020
@nickvergessen
Copy link
Member

The hub icon list was 7 icons?

@blizzz
Copy link
Member Author

blizzz commented Jan 24, 2020

The hub icon list was 7 icons?

  1. I am confused, too :)

On a fresh 18 install from the tar ball, those I added will be installed if you agree to.

  • Files is shipped, of course
  • Photos is shipped
  • Activity is shipped
  • Talk is neither shipped nor offered to install
  • contacts, calendar, mail, only office are all covered

I am absolutely eager to adding Talk, but we should be consistent.

@rullzer
Copy link
Member

rullzer commented Jan 24, 2020

The hub icon list was 7 icons?

1. I am confused, too :)

On a fresh 18 install from the tar ball, those I added will be installed if you agree to.

* Files is shipped, of course

* Photos is shipped

* Activity is shipped

* Talk is neither shipped nor offered to install

* contacts, calendar, mail, only office are all covered

I am absolutely eager to adding Talk, but we should be consistent.

Yes I noticed this as well. Talk should be on that list. I will create a PR for the install. I could have sworn it was there maybe a force push somewhere removed it.

skjnldsv
skjnldsv approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure (aside from comment)

@blizzz
Copy link
Member Author

blizzz commented Jan 24, 2020

The hub icon list was 7 icons?

1. I am confused, too :)

On a fresh 18 install from the tar ball, those I added will be installed if you agree to.

* Files is shipped, of course

* Photos is shipped

* Activity is shipped

* Talk is neither shipped nor offered to install

* contacts, calendar, mail, only office are all covered

I am absolutely eager to adding Talk, but we should be consistent.

Yes I noticed this as well. Talk should be on that list. I will create a PR for the install. I could have sworn it was there maybe a force push somewhere removed it.

And so Talk is added here.

@blizzz
Copy link
Member Author

blizzz commented Jan 24, 2020

/backport to stable18

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 24, 2020
@rullzer rullzer merged commit aa950ff into master Jan 27, 2020
@rullzer rullzer deleted the enh/noid/hub-bundle branch January 27, 2020 07:20
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 27, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #19153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@JanDragon JanDragon JanDragon approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@GretaD GretaD Awaiting requested review from GretaD

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
5 participants
@blizzz @nickvergessen @rullzer @skjnldsv @JanDragon