Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that is an array before accessing it #18301

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Verify that is an array before accessing it #18301

merged 1 commit into from
Dec 10, 2019

Conversation

georgehrke
Copy link
Member

There are cases where deleteCalendarObject is called for non-existing objects.
It should not error in these cases.

@georgehrke georgehrke added the 3. to review Waiting for reviews label Dec 9, 2019
rullzer
rullzer approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure...

🐘

@rullzer rullzer added this to the Nextcloud 18 milestone Dec 10, 2019
@rullzer rullzer merged commit 58da7c5 into master Dec 10, 2019
@rullzer rullzer deleted the bugfix/noid/fix_array_access_on_non_array branch December 10, 2019 09:25
@rullzer rullzer mentioned this pull request Dec 11, 2019
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@georgehrke @rullzer @ChristophWurst