-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dedicated page for the recommended apps installation #18233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the trick and already looks a lot better!
@@ -131,26 +129,26 @@ export default { | |||
return OC.Util.naturalSortCompare(sortStringA, sortStringB) | |||
}) | |||
|
|||
switch (this.category) { | |||
case 'installed': | |||
if (this.category === 'installed') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much cleaner :p
/compile fixup / |
I will only have time to look into this in the next days as I’ll be traveling. If someone else wants to have a quick look (a lot of these things look nice already on the 2FA choice page for example, maybe patterns to get from there):
|
d24f097
to
00adb21
Compare
/compile amend / |
00adb21
to
158c14f
Compare
Signed-off-by: Christoph Wurst <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
158c14f
to
302558c
Compare
Todo
Current state