Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dedicated page for the recommended apps installation #18233

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 4, 2019

Todo


Current state

Bildschirmfoto von 2019-12-05 11-28-11

old versions ![Bildschirmfoto von 2019-12-05 10-33-15](https://user-images.githubusercontent.com/1374172/70222739-adda3900-174a-11ea-8d6d-04428091134d.png) ![Bildschirmfoto von 2019-12-05 10-03-12](https://user-images.githubusercontent.com/1374172/70220266-9ac56a00-1746-11ea-94a3-192fce07491e.png) ![Bildschirmfoto von 2019-12-04 19-58-06](https://user-images.githubusercontent.com/1374172/70173591-78decf80-16d3-11ea-8e5e-a97af766a5bf.png)

@rullzer rullzer mentioned this pull request Dec 11, 2019
43 tasks
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the trick and already looks a lot better!

@ChristophWurst ChristophWurst marked this pull request as ready for review December 11, 2019 14:58
@@ -131,26 +129,26 @@ export default {
return OC.Util.naturalSortCompare(sortStringA, sortStringB)
})

switch (this.category) {
case 'installed':
if (this.category === 'installed') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner :p

@rullzer
Copy link
Member

rullzer commented Dec 11, 2019

/compile fixup /

@jancborchardt
Copy link
Member

jancborchardt commented Dec 11, 2019

I will only have time to look into this in the next days as I’ll be traveling. If someone else wants to have a quick look (a lot of these things look nice already on the 2FA choice page for example, maybe patterns to get from there):

  • App title should be white (same as text color)
  • App icon should be white (same as text color)
  • App icon is a bit large in comparison to the text.
  • App description text should be left-aligned
  • Spacing between app title and app description is too much – could be halved
  • Error should just be bold (in a <strong> element) instead of in a class="error" container
  • The width of the dialog should be fixed to what we had before. See Container on update screen is too wide Container on update screen is too wide #17556
  • The "Go back" link is a bit confusing? Should it be "Cancel"?

@rullzer rullzer force-pushed the enhancement/recommended-apps-page branch from d24f097 to 00adb21 Compare December 11, 2019 18:55
@rullzer
Copy link
Member

rullzer commented Dec 11, 2019

/compile amend /

Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@rullzer rullzer force-pushed the enhancement/recommended-apps-page branch from 158c14f to 302558c Compare December 12, 2019 07:13
@rullzer rullzer merged commit a33a4c5 into master Dec 12, 2019
@rullzer rullzer deleted the enhancement/recommended-apps-page branch December 12, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants