Disable Clear-Site-Data for Chrom* (and Opera, Brave, etc) #17784
Conversation
|
I'm really not sure :/ |
Chrome (and everything else based on chromium) ;) It's working fine with Firefox.
https://bugs.chromium.org/p/chromium/issues/detail?id=762417 They merged a fix for Chromium 77 (Stable Release Tue, Sep 10, 2019). Added this information to #9179 (comment). Let's wait for feedback ;) |
|
I think we should turn it off by default for now. There more than 70 reports over at #9179. We can't fix it but people will always think it's related to Nextcloud. According to https://bugs.chromium.org/p/chromium/issues/detail?id=762417#c37 GitHub does not send the header anymore for chrome. |
skjnldsv
added
4. to release
|
I don't like it. Having it as a config option doesn't help. Because this is not something a lot of users can change. |
skjnldsv
added
2. developing
Did not thought of this! Nice idea! :) |
kesselb
force-pushed
the
enh/disable-clear-site-data-via-config
branch
3 times, most recently
from
e037e06
to
49fac48
Compare
Fine by me but I'm not a fan :) |
kesselb
added
3. to review
kesselb
changed the title
kesselb
changed the title
core/Controller/LoginController.php
Outdated
| @@ -128,7 +128,11 @@ public function logout() { | |||
|
|
|||
| $this->session->set('clearingExecutionContexts', '1'); | |||
| $this->session->close(); | |||
| $response->addHeader('Clear-Site-Data', '"cache", "storage"'); | |||
|
|
|||
| if (!$this->request->isUserAgent(['#Chrome/#'])) { | |||
There was a problem hiding this comment.
we have a list of valid user agent somewhere in a php class iirc :)
There was a problem hiding this comment.
Yes. They are a bit more specific than '#Chrome/#' 😆
kesselb
force-pushed
the
enh/disable-clear-site-data-via-config
branch
from
49fac48
to
8c01bb9
Compare
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
enh/disable-clear-site-data-via-config
branch
from
8c01bb9
to
9378a6b
Compare
Close #9179 (again)
I think Clear-Site-Data is a good feature but it will slow down the logout for chromium based browsers. For some reason clearing the site data (see #9179 (comment) and #9179 (comment)) takes a while. There is nothing we can do.
People will always complain to their administrators about the slow logout. We should give them a way to opt out. I've been thinking about sending the header only for firefox but this makes things even more complicated.
Since this patch has no real impact I would like to ask for a backport to 17.