Activities for calendars, events and todos #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @tcitworld and @LukasReschke to be potential reviewers. |
tcitworld
reviewed
Oct 13, 2016
| @@ -357,10 +357,8 @@ public function testPublications() { | |||
| $calendar->setPublishStatus(false); | |||
| $this->assertEquals(false, $calendar->getPublishStatus()); | |||
|
|
|||
| $publicCalendarURI = md5($this->config->getSystemValue('secret', '') . $calendar->getResourceId()); | |||
5 tasks
nickvergessen
force-pushed
the
dav-events
branch
from
094b031
to
22b412f
Compare
|
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
dav-events
branch
from
22b412f
to
7a0e003
Compare
|
Added a bunch of tests, will add the missing tests later in another PR. |
|
Tested and works - but only with nextcloud/activity#64 👍 |
|
cc @rullzer - review time |
Current coverage is 58.11% (diff: 22.74%)@@ master #1733 diff @@
==========================================
Files 1088 1090 +2
Lines 62149 63854 +1705
Methods 6937 7169 +232
Messages 0 0
Branches 0 0
==========================================
+ Hits 35886 37107 +1221
- Misses 26263 26747 +484
Partials 0 0
|
|
LGTM |
|
@mmluqman when you switch to Nextcloud, you can have activities for calendar and task changes already since version 11. I just saw you commented on the ownCloud feature request for it. So I thought you might be interested in it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports:
Todos:
Ref #745
@MorrisJobke @LukasReschke @rullzer please review :)