Fix apptoken creation #17253
Merged
Fix apptoken creation #17253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
nickvergessen,
ChristophWurst,
GretaD and
skjnldsv
|
I'm not sure how this slipped. As I tested it before. Maybe something got mixed up when squasing/rebasing. |
nickvergessen
approved these changes
Sep 25, 2019
Seems there was a small bug in #15936 This inverts the check and add the property Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
fix/apptoken_creation
branch
from
59e545b
to
17a6bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems there was a small bug in #15936
This inverts the check and add the property
Signed-off-by: Roeland Jago Douma [email protected]