Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always provide theme color for default personal calendar #17148

Merged

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Sep 15, 2019

Before this calendar-color wasn't defined for default calendar

Edited by @georgehrke:
fixes #11256

@tcitworld tcitworld added the 3. to review Waiting for reviews label Sep 15, 2019
@tcitworld tcitworld force-pushed the always-provide-color-to-default-personal-calendar branch from de8a959 to dc04154 Compare September 15, 2019 11:27
@nickvergessen
Copy link
Member

Should have a cap at that, so e.g. white doesnt cause issues? Or black on dark theme

@tcitworld
Copy link
Member Author

Should have a cap at that, so e.g. white doesnt cause issues? Or black on dark theme

I feel like it would be more proper to handle this in the theme app. On calendar app side we can fix things by using a border around the calendar color.

@jancborchardt
Copy link
Member

Should have a cap at that, so e.g. white doesnt cause issues? Or black on dark theme

So we already do have a way to handle that, it’s the var(--color-primary-element) – this ensures it’s capped at a certain grey to be visible.

@georgehrke
Copy link
Member

So we already do have a way to handle that, it’s the var(--color-primary-element) – this ensures it’s capped at a certain grey to be visible.

Well, but we can't rely on that in CalDAV. iOS calendar, Lightning and other clients have no idea what var(--color-primary-element) is

@jancborchardt
Copy link
Member

So we already do have a way to handle that, it’s the var(--color-primary-element) – this ensures it’s capped at a certain grey to be visible.

Well, but we can't rely on that in CalDAV. iOS calendar, Lightning and other clients have no idea what var(--color-primary-element) is

Right – I assume we might have a way in the theming app to hand that over? cc @juliushaertl?

@juliusknorr
Copy link
Member

Right – I assume we might have a way in the theming app to hand that over? cc @juliushaertl?

There is no real API for that yet, but the calculation is already done in PHP:

public function elementColor($color) {

@ChristophWurst

This comment has been minimized.

Before this calendar-color wasn't defined for default calendar

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld force-pushed the always-provide-color-to-default-personal-calendar branch from dc04154 to 4d5bb48 Compare June 25, 2021 12:21
@szaimen szaimen added this to the Nextcloud 23 milestone Jun 25, 2021
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish feature: dav feature: theming and removed 3. to review Waiting for reviews labels Jun 25, 2021
@tcitworld tcitworld force-pushed the always-provide-color-to-default-personal-calendar branch from 4d5bb48 to 8927205 Compare June 25, 2021 12:26
@tcitworld
Copy link
Member Author

I actually don't remember for sure why we wanted to have VEVENTs-only in the default calendar. Probably for people who were deleting the default task list without noticing they were deleting all of their events at the same time.

@juliusknorr
Copy link
Member

Failure looks unrelated but i retriggered drone to be sure since I haven't seen that one failing so far:

/drone/src/tests/acceptance/features/app-files-tags.feature:22

@nickvergessen nickvergessen merged commit 8ebbd91 into master Jul 2, 2021
@nickvergessen nickvergessen deleted the always-provide-color-to-default-personal-calendar branch July 2, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: dav feature: theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

personal calendar for newly created users has no calendar color set
8 participants