-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always provide theme color for default personal calendar #17148
Always provide theme color for default personal calendar #17148
Conversation
de8a959
to
dc04154
Compare
Should have a cap at that, so e.g. white doesnt cause issues? Or black on dark theme |
I feel like it would be more proper to handle this in the theme app. On calendar app side we can fix things by using a border around the calendar color. |
So we already do have a way to handle that, it’s the |
Well, but we can't rely on that in CalDAV. iOS calendar, Lightning and other clients have no idea what |
Right – I assume we might have a way in the theming app to hand that over? cc @juliushaertl? |
There is no real API for that yet, but the calculation is already done in PHP: server/apps/theming/lib/Util.php Line 82 in 30d985b
|
This comment has been minimized.
This comment has been minimized.
Before this calendar-color wasn't defined for default calendar Signed-off-by: Thomas Citharel <[email protected]>
dc04154
to
4d5bb48
Compare
Signed-off-by: Thomas Citharel <[email protected]>
4d5bb48
to
8927205
Compare
I actually don't remember for sure why we wanted to have |
Failure looks unrelated but i retriggered drone to be sure since I haven't seen that one failing so far:
|
Before this calendar-color wasn't defined for default calendar
Edited by @georgehrke:
fixes #11256