Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app name to the call #1683

Merged
merged 1 commit into from
Oct 10, 2016
Merged

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 10, 2016

Regression from 69b063f aka #1225
Fix #1437

Steps

  1. ./occ config:system:set appcodechecker --value true --type boolean
  2. Install an app from the app store

@MorrisJobke @rullzer @LukasReschke

Regression from 69b063f

Signed-off-by: Joas Schilling <[email protected]>
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @georgehrke and @icewind1991 to be potential reviewers.

@MorrisJobke
Copy link
Member

Tested and works 👍

Copy link

@mightyBroccoli mightyBroccoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By doing this change it is possible to use the Appstore with appcodechecker enabled atleast for my 5 machines this change is perfect.

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 10, 2016
@rullzer
Copy link
Member

rullzer commented Oct 10, 2016

LGTM

@rullzer rullzer merged commit a81d045 into master Oct 10, 2016
@rullzer rullzer deleted the issue-1437-installing-app-with-code-checker branch October 10, 2016 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants