Nested recursion breaking max nested level for parent comment calculation

[nickvergessen]

The bug had no effect so far because the comments app does not allow replying.
However the integration tests I'm writing for nextcloud/spreed#2000 failed with the following error, when replying to a message which was already a reply:

Error: Maximum function nesting level of '256' reached, aborting! at …/server/lib/private/Comments/Manager.php#243

[nickvergessen]

/backport to stable16

[rullzer]

sure

[blizzz]

The else is unnecessary. Why would this prevent an infinite loop however?

[backportbot-nextcloud]

backport to stable16 in #16524

[danxuliu]

The else is unnecessary. Why would this prevent an infinite loop however?

Not the else, but the change from $comment->getId() to $comment->getParentId() (first commit).

[blizzz]

The else is unnecessary. Why would this prevent an infinite loop however?

Not the else, but the change from $comment->getId() to $comment->getParentId() (first commit).

Gosh, and i doublechecked that :-/ more ☕ needed. makes sense anyway :)