Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move log detail aggregation and reuse it in syslog/systemd logger #16416

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Move log detail aggregation and reuse it in syslog/systemd logger #16416

merged 1 commit into from
Jul 17, 2019

Conversation

juliusknorr
Copy link
Member

This way we also include details like the request id in the log when using different logging backends like syslog or systemd log.

@juliusknorr juliusknorr added enhancement 3. to review Waiting for reviews labels Jul 16, 2019
@juliusknorr juliusknorr added this to the Nextcloud 17 milestone Jul 16, 2019
@juliusknorr juliusknorr added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 16, 2019
@MorrisJobke MorrisJobke mentioned this pull request Jul 16, 2019
Merged
28 tasks
rullzer
rullzer approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 17, 2019
MorrisJobke
MorrisJobke approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 223a91d into master Jul 17, 2019
@MorrisJobke MorrisJobke deleted the enh/log-details branch July 17, 2019 09:43
@MorrisJobke MorrisJobke mentioned this pull request Jul 17, 2019
Closed
@joshtrichards joshtrichards mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb left review comments

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.
4 participants
@juliusknorr @rullzer @MorrisJobke @kesselb