Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide collaborative tag input when empty #1469

Merged
merged 4 commits into from
Sep 21, 2016
Merged

Conversation

nickvergessen
Copy link
Member

Checkbox 1.1 from #1465

@jancborchardt @MorrisJobke

No tags

files_-nextcloud-_2016-09-20_18 08 44

Has tags

files_-nextcloud-_2016-09-20_18 09 20

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @skjnldsv and @LukasReschke to be potential reviewers

@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg xmlns="http://www.w3.org/2000/svg" height="16" width="16" version="1.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add viewBox="0 0 16 16" for proper scaling in Firefox ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@MorrisJobke
Copy link
Member

MorrisJobke commented Sep 20, 2016

Tested and works (even if IE and Firefox) ;) 👍

@jancborchardt
Copy link
Member

jancborchardt commented Sep 20, 2016

Two things we need to fix:

  • »Tags« action should have some padding and space to the left to differentiate from file info
  • when the input field shows, there is proper whitespace to the tab bar below. But the default state has insufficient whitespace.

@jancborchardt
Copy link
Member

LGTM, now with proper padding!

@karlitschek Requesting backport since the tags field really really distracts from the Sharing input field, as confirmed by @schiessle, @oparoz and multiple others.

@jancborchardt jancborchardt merged commit f383b2a into master Sep 21, 2016
@jancborchardt jancborchardt deleted the hide-empty-tag-input branch September 21, 2016 08:39
@karlitschek
Copy link
Member

hmm. bigger change. but backport makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants