-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide collaborative tag input when empty #1469
Conversation
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @skjnldsv and @LukasReschke to be potential reviewers |
@@ -0,0 +1,5 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
<svg xmlns="http://www.w3.org/2000/svg" height="16" width="16" version="1.0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add viewBox="0 0 16 16"
for proper scaling in Firefox ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Tested and works (even if IE and Firefox) ;) 👍 |
Two things we need to fix:
|
LGTM, now with proper padding! @karlitschek Requesting backport since the tags field really really distracts from the Sharing input field, as confirmed by @schiessle, @oparoz and multiple others. |
hmm. bigger change. but backport makes sense 👍 |
Checkbox 1.1 from #1465
@jancborchardt @MorrisJobke
No tags
Has tags