Move personal auth token settings to Vue #14392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This also reduces the number of requests on the personal security settings page by three. |
ChristophWurst
force-pushed
the
refactor/auth-token-Vue
branch
from
6e77276
to
67a1397
Compare
ChristophWurst
requested review from
rullzer,
kesselb,
skjnldsv,
juliusknorr and
tobiasKaminsky
ChristophWurst
added
3. to review
juliusknorr
approved these changes
Feb 28, 2019
ChristophWurst
force-pushed
the
refactor/auth-token-Vue
branch
3 times, most recently
from
f1b9af3
to
7cf3718
Compare
rullzer
requested changes
Feb 28, 2019
Signed-off-by: Christoph Wurst <[email protected]> Always crate OC.Settings, even if not used Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
refactor/auth-token-Vue
branch
from
7cf3718
to
4b72475
Compare
Yep, https://github.com/nextcloud/server/pull/14392/files#diff-f57c51aacf630692a4a5d90e51cf3f11R86 was missing. |
|
🎉 |
rullzer
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #429
Todo
Optional
Bugs
<a>is clicked. The mouse has to be moved away and back to make it visible