Add guest navigation type #14266
Merged
Add guest navigation type #14266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
blizzz,
nickvergessen,
rullzer and
MorrisJobke
rullzer
approved these changes
Feb 18, 2019
|
This change is causing #20572. Before: The only dependency for getShortFooter seems to be the theming app. After: NavigationManager is used to generate all navigation items and assumes that every app is loaded (otherwise the routes are not available). That works until you are trying to render a error page and some apps are not loaded. A check if the app is loaded before generating the navigation item seems to work. But that's just another workaround. |
|
@kesselb The comment links to this pr instead of an issue ;) |
|
Happens to me all the time ;) Now it's the right link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows apps like nextcloud/external#131 to add links to the public page footer.
The existing privacy/imprint links from the theming app will be kept as they are.
Part of implementing nextcloud/external#111