take out support for parallel search #14105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* it is undocumented in PHP documentation * since it does not work with paged search, we do not take advantage of it as of c868892 Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
techdebt/noid/ldap-refactor-search
branch
from
8341854
to
f5cd138
Compare
|
I get this in the wizard: |
|
@MorrisJobke it's merely a dump, barely tested, therefore the developing label. |
I just wanted to give first feedback ;) |
|
@blizzz What is the status here? We are close to the beta 1. I guess this should go into 18, right? |
|
yes, 18, nothing urgent |
|
not relevant anymore, also incorporated in #20037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #13865
(still pondering whether it might make sense to keep it in place, but use it when paged search is turned off. could be useful for edge cases, e.g. certain LDAP directories + multiple bases. performance testing could be useful here, too).