Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable & disable multiple apps at once #13850

Merged
merged 6 commits into from
Feb 21, 2019
Merged

Enable & disable multiple apps at once #13850

merged 6 commits into from
Feb 21, 2019

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jan 27, 2019 •
edited
Loading

Close #11274

Enable & disable multiple apps at once.

@kesselb kesselb force-pushed the feature/11274/enable-disable-multiple-apps branch 6 times, most recently from f0fe71b to b6db89b Compare January 28, 2019 17:25
@kesselb
Enable multiple apps at once
08907ee 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
Disable multiple apps at once
03d3192 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
Strict Types, Return Types
76b5f44 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
Add install logic for enable command
75b7d6a 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
Use contacts instead of logreader
bb2d8ba 
Logreader is not distributed by app store because shipped by default.

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the feature/11274/enable-disable-multiple-apps branch from b6db89b to bb2d8ba Compare February 19, 2019 20:03
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 19, 2019
@kesselb kesselb changed the title WIP: enable & disable multiple apps at once Enable & disable multiple apps at once Feb 19, 2019
@kesselb kesselb added this to the Nextcloud 16 milestone Feb 19, 2019
MorrisJobke
MorrisJobke approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@kesselb
Fix access to groupManager
1d10687 
Signed-off-by: Daniel Kesselberg <[email protected]>
@nickvergessen nickvergessen merged commit c84c13f into master Feb 21, 2019
@nickvergessen nickvergessen deleted the feature/11274/enable-disable-multiple-apps branch February 21, 2019 13:39
@kesselb
Copy link
Contributor Author

kesselb commented Feb 21, 2019

@enoch85 @J0WI @kyrofa fyi. Could be useful for your provision scripts 🚀

@enoch85
Copy link
Member

enoch85 commented Feb 21, 2019

Thanks for this @kesselb!

@blizzz blizzz mentioned this pull request Feb 25, 2019
Closed
aszlig added a commit to aszlig/avonc that referenced this pull request Nov 5, 2020
@aszlig
Enable and disable multiple apps at once
504c7de 
The app:enable and app:disable subcommands accept multiple app IDs since
Nextcloud 16[1] and since we no longer support Nextcloud 16 or even 17,
we can now safely add all the apps we need to enable or disable in one
shot, saving a bit of startup time.

[1]: nextcloud/server#13850

Signed-off-by: aszlig <[email protected]>
This was referenced Jul 27, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
4 participants
@kesselb @enoch85 @nickvergessen @MorrisJobke