Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix social sharing apps integration #13738

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Fix social sharing apps integration #13738

merged 2 commits into from
Jan 23, 2019

Conversation

juliusknorr
Copy link
Member

This fixes the integration of socialsharing_* apps that has been broken during the multiple share link implementation.

Fixes nextcloud/socialsharing#29

@juliusknorr
Copy link
Member Author

/backport to stable15

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure unrelated. Code looks good! 👍

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, code looks good 👍

I have also run in local the acceptance tests that timed out in Drone (app-files-sharing) and everything passed.

@rullzer rullzer merged commit 308d5d5 into master Jan 23, 2019
@rullzer rullzer deleted the bugfix/noid/socialsharing branch January 23, 2019 08:54
@backportbot-nextcloud
Copy link

The backport to stable15 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

socialsharing_email 1.0.5 kills public sharing by link
5 participants