Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update select2 requirement from to #13494

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jan 10, 2019

Updates the requirements on select2 to permit the latest version.

Changelog

Sourced from select2's changelog.

4.0.5

Bug fixes

  • Replace autocapitalize=off with autocapitalize=none (#4994)

Translations

  • Vietnamese: remove an unnecessary quote mark (#5059)
  • Czech: Add missing commas and periods (#5052)
  • Spanish: Update the 'errorLoading' message (#5032)
  • Fix typo in Romanian (#5005)
  • Improve French translation (#4988)
  • Add Pashto translation (ps) (#4960)
  • Add translations for lower and upper Sorbian (dsb and hsb) (#4949)
  • Updates to Slovak (#4915)
  • Fixed Norwegian inputTooShort message (#4817, 4896)
  • Add Afrikaans translation (af) (#4850)
  • Add Bosnian translation (bs) (#4504)

4.0.4

New features / Improvements

  • Make tag matching case insensitive [https://github.com/select2/select2/commit/cb9a90457867ffb14c7b1550bb67e872e0a5c2dd, https://github.com/select2/select2/commit/1167bace78cd3b1a918c1b04f3bac54674eab62b]
  • Support selecting options with blank or 0 option values [https://github.com/select2/select2/commit/16b4840c0e2df0461998e3b464ee0a546173950d, https://github.com/select2/select2/commit/0358ee528765157234643d289bce6b8ca5889c72]

Bug fixes

  • Fix issue with entire form losing focus when tabbing away from a Select2 control (#4419)
  • Fix UMD support for CommonJS [https://github.com/select2/select2/commit/45a877345482956021161203ac789c25f40a7d5e]

Documentation

Translations

  • Add errorLoading Hungarian translation [https://github.com/select2/select2/commit/7d1d13352321e21670ff1c6cba7413aa264fd57a]
  • Add errorLoading German translation [https://github.com/select2/select2/commit/4df965219ea4c39147fde9335bc260840465933a]
  • Add Slovene language [https://github.com/select2/select2/commit/8e6422c570a87da8d89c45daf0d253695a943c84]
  • Add errorLoading Galician translation [https://github.com/select2/select2/commit/8fcc6202c37f4e06d951342bf142a3b906b6b8e3]
  • Add errorLoading Thai translation [https://github.com/select2/select2/commit/625fc78ee616baedf64aa37357403b4b72c7363c]
  • Add searching and errorLoading Finnish translations [https://github-redirect.dependabot.com/Add missing finnish translations select2/select2#4730]
  • Add errorLoading Turkish translation [https://github.com/select2/select2/commit/fd4a0825315c7055347726d5818c999279f96ff8, https://github.com/select2/select2/commit/751b36767f9f28b9de9428d5e8035c9a404915d9]
  • Add Armenian language [https://github.com/select2/select2/commit/f6fa52dcc02341df1523f50348f2effc54ee2911]

4.0.3

This is the third bugfix release of Select2 4.0.0. It builds upon the second bugfix release and fixes many common issues.

... (truncated)
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 10, 2019

@dependabot FYI: that title doesn't look right 😉

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/select2-4.0.5 branch 3 times, most recently from b44c30d to 3753afd Compare January 11, 2019 08:23
@@ -39,7 +39,7 @@
"jstimezonedetect": "^1.0.6",
"marked": "^0.3.6",
"moment": "^2.23.0",
"select2": "https://github.com/select2/select2#3.4.8",
"select2": "https://github.com/select2/select2#4.0.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristophWurst Any reason there are two entries of select2?

24: "Select2": "git+https://github.com/select2/select2.git#3.4.8",

42: "select2": "https://github.com/select2/select2#4.0.5",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: @ChristophWurst does not know how to handle npm.

There was an issue with the lockfile (npm error shown) and I tried different things to resolve them, resulting in two different versions. I've already added that to my todo as @rullzer noticed this as well :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristophWurst think you can fix the lockfile error by running (to install latest version):

npm remove select2
npm remove Select2
npm install select2/select2#4.0.5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@feelepxyz
Copy link

@ChristophWurst @greysteil fixed it here after this PR was created dependabot/dependabot-core@ffd8f50

@greysteil
Copy link

greysteil commented Jan 11, 2019

Yep, @feelepxyz is spot on - just hadn't been deployed. Future PRs should be fixed - it's deployed now!

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/select2-4.0.5 branch 3 times, most recently from 472f364 to d1cbcd8 Compare January 13, 2019 09:58
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/select2-4.0.5 branch from d1cbcd8 to d16c913 Compare January 14, 2019 08:30
@ChristophWurst
Copy link
Member

From https://select2.org/upgrading/new-in-40

This release contains many breaking changes

@dependabot ignore this major version

@ChristophWurst ChristophWurst deleted the dependabot/npm_and_yarn/select2-4.0.5 branch January 14, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants