-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update select2 requirement from to #13494
Conversation
@dependabot FYI: that title doesn't look right 😉 |
b44c30d
to
3753afd
Compare
@@ -39,7 +39,7 @@ | |||
"jstimezonedetect": "^1.0.6", | |||
"marked": "^0.3.6", | |||
"moment": "^2.23.0", | |||
"select2": "https://github.com/select2/select2#3.4.8", | |||
"select2": "https://github.com/select2/select2#4.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChristophWurst Any reason there are two entries of select2?
24: "Select2": "git+https://github.com/select2/select2.git#3.4.8",
42: "select2": "https://github.com/select2/select2#4.0.5",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes: @ChristophWurst does not know how to handle npm.
There was an issue with the lockfile (npm error shown) and I tried different things to resolve them, resulting in two different versions. I've already added that to my todo as @rullzer noticed this as well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChristophWurst think you can fix the lockfile error by running (to install latest version):
npm remove select2
npm remove Select2
npm install select2/select2#4.0.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
@ChristophWurst @greysteil fixed it here after this PR was created dependabot/dependabot-core@ffd8f50 |
Yep, @feelepxyz is spot on - just hadn't been deployed. Future PRs should be fixed - it's deployed now! |
472f364
to
d1cbcd8
Compare
Updates the requirements on [select2](https://github.com/select2/select2) to permit the latest version. - [Release notes](https://github.com/select2/select2/releases) - [Changelog](https://github.com/select2/select2/blob/develop/CHANGELOG.md) - [Commits](select2/select2@3.4.8...ebf10c9) Signed-off-by: dependabot[bot] <[email protected]>
d1cbcd8
to
d16c913
Compare
From https://select2.org/upgrading/new-in-40
@dependabot ignore this major version |
Updates the requirements on select2 to permit the latest version.
Changelog
Sourced from select2's changelog.
Commits
ebf10c9
compile+minify for 4.0.5 releasea0df1e8
update changelog633e707
Merge branch 'patch-1' of https://github.com/frkami123/select2 into hotfix2a21ade
Merge branch 'patch-2' of https://github.com/ettiennelouw/select2 into hotfixa3952c7
Replaceautocapitalize=off
withautocapitalize=none
(#4994)65f85c3
Merge branch 'master' of https://github.com/mnrafg/select2 into hotfix46ed8ae
bump version to 4.0.5b559310
extra-last-resortbf6c3c9
last resortf0a3058
set platform for all browsers in grunt-saucelabs testsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking
Bump now
in your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge@dependabot reopen
will reopen this PR if it is closed@dependabot ignore this [patch|minor|major] version
will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard:
Finally, you can contact us by mentioning @dependabot.