Load apps that have a dav type set before the dav server plugins #12448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
added
bug
3. to review
juliusknorr
requested review from
rullzer,
nickvergessen,
MorrisJobke and
blizzz
blizzz
reviewed
Nov 14, 2018
| @@ -103,9 +103,7 @@ private function populate() { | |||
| if (!isset($info['types']) || !in_array('dav', $info['types'], true)) { | |||
| continue; | |||
| } | |||
| // FIXME: switch to public API once available | |||
| // load app to make sure its classes are available | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
then we should add this type for comments, too, right? Not sure which other apps have plugins. (it does incorporate logging, but we should not rely on that) |
The comments plugins are still located in the dav app, so for now we don't need that i guess. |
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/dav-loadapps
branch
from
7ade85a
to
5a5d46b
Compare
|
/backport to stable14 |
|
/backport to stable13 |
|
backport to stable13 in #12594 |
|
backport to stable13 in #12595 |
|
/backport to stable14 |
|
backport to stable14 in #12596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement comments support for an app, it is required to register a comments entity:
This is usually done in the app.php. When using the comments dav endpoint, the app is only loaded if either one of the types logging/authentication/filesystem is set in the info.xml, but this will remove the ability to enable the app just for a specific group. See
We already have a type 'dav' that is used for loading dav plugins, so this PR will make sure we load app apps with a type 'dav' set in info.xml before registering plugins in the DAV Server class.
cc @nickvergessen @blizzz