-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UniqueConstraintViolationException while insert into oc_file_locks #12413
Fix UniqueConstraintViolationException while insert into oc_file_locks #12413
Conversation
* fixes #9305 by not being prone to the race condition in insertIfNotExists * fixes #6899 by not using a query that can result in a deadlock * replaces the insertIfNotExists call with an insert which is wrapped into a try-catch block * followup to #12371 Signed-off-by: Morris Jobke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense
Since this will be backported, is there a PR or issue I can follow to track when this makes it into v14? |
#12433 will be part of https://github.com/nextcloud/server/milestone/57 |
HI, just upgraded to Nextcloud 15.0.4, the problem persists. The postgresql logs are polluted by these 5 times a second:
Everything seems to work fine, but this is slowing down the system a lot which crawls under postgresql load. |
Fix for this is in #13721 |
Issue is backup again in #6899 |
I would back port this one to stable13 and stable14 as well because it is a smaller and not that invasive version of #12371 and it also fixes the deadlocks.