Background job to cleanup leftover chunked uploads #12227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested changes
Jan 3, 2019
|
I guess this is addressing #8759 |
|
@MorrisJobke yes. But this is only for upload using the new chunked upload. However most are now days. |
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
bugfix/cleanu_upload_folders
branch
from
2768cd6
to
adb2b9a
Compare
rullzer
added
3. to review
rullzer
requested review from
ChristophWurst,
blizzz,
icewind1991 and
juliusknorr
|
@MorrisJobke ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a chunked uploads fails for some reason the chunks should be cleaned up at some point in time. Else they can quickly fillup a disk.
When a chunked collection is created a backgroundjob is inserted.
This job is deleted when the chunked upload completes sucsessfully
The job will check if all files have an mtime of more than 24 hours. If so it will kill the folder. So as long as you upload 1 chunk every 24 hours it will not kill them.
TODO:
CC: @MorrisJobke since we discussed this recently