Sidebar fixes, mostly fixing design of tabs #12180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
jancborchardt
added
bug
design
jancborchardt
requested review from
nickvergessen,
georgehrke,
juliusknorr,
kevgathuku,
skjnldsv and
danxuliu
|
Can I suggest to prevent the shrinking of the selected tab? :) |
|
CI is not happy though |
❤️ @jancborchardt For consistency, could you change this (mainly icons above text) in Talk too? Thanks! :-) (and there is no hurry, it can wait a few days ;-) )
One timeout, one unrelated failure due to a known race condition, and a failure that looks like a hiccup... but I will restart the build to be sure ;-) |
MorrisJobke
approved these changes
Nov 1, 2018
This will look wonky and not stable. The tab widths change then and you can’t use muscle memory. :) |
I guess not 🤣 EDIT: AH! you answered at the same time :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tabs in the Files sidebar were utterly broken, which is very obvious on any screen which is not 4k resolution, or as soon as the 4th tab shows. This is especially visible now because we added nice icons to all the tabs.
🤢
So here you go with nicer tab layout:
Even if we add Chat it works – cc @danxuliu
And even if we really loose our minds 🤯
Please review @nextcloud/designers, also cc @nickvergessen & @georgehrke for evaluation with Talk and Calendar apps.
Now this is only a stop-gap solution of course. We still need to work towards limiting the amount of tabs in there as per Sidebar standardization #10289 and Sidebar: combine file Activity, Comments and Versions into unified »Activity« timeline tab #658