Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Change password expiration time from 12h to 7d #11857

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

MorrisJobke
Copy link
Member

We use the same logic for creating accounts without a password and there the 12h is a bit short. Users don't expect that the signup link needs to be clicked within 12h - 7d should be a more expected behavior.

Backport of #10942

We use the same logic for creating accounts without a password and there the 12h is a bit short. Users don't expect that the signup link needs to be clicked within 12h - 7d should be a more expected behavior.

Signed-off-by: Morris Jobke <[email protected]>
@Knot3n
Copy link

Knot3n commented Oct 16, 2018

i know that its already "approved" but 7 days is a long time for a signup link.

24h to 48h would fit more into it. After that it should be possible to request a new link.
If the comment here does not fit in or is obsolete, then I'm sorry.

@MorrisJobke
Copy link
Member Author

i know that its already "approved" but 7 days is a long time for a signup link.

24h to 48h would fit more into it. After that it should be possible to request a new link.
If the comment here does not fit in or is obsolete, then I'm sorry.

We get many complains also from businesses where admins send this out and after the weekend the link is invalid. It's also a personalized and quite long token. We are thinking about adding some easy to use reset password links additionally there.

Anyways - thanks for the feedback.

@rullzer rullzer merged commit e3a2b9e into stable13 Oct 17, 2018
@rullzer rullzer deleted the backport/10942/longer-password-reset-time branch October 17, 2018 20:14
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants