allow to create multiple link shares via share api

[schiessle]

• Allow to create multiple share links (API level)
• Get multiple share links (API level)
• allow to give share links unique names (API level)
• allow to change unique name of a share (API level)
• Allow to create multiple share links (web ui)
• Show multiple share links (web ui)
• allow to give share links unique names (web ui)
• allow to change unique name of a share (web ui)

for ux discussion, etc see #11169
Fix #10434
Closes #11537 : not possible, we cannot wait for the request of a new share to be done as the .done or success hooks generate a new scope and a clipboard triggered by a click needs to be in a direct call of a function triggered by an event :(
Fix #11169

[schiessle]

cc @AndyScherzinger @tobiasKaminsky @marinofaggiana @camilasan @rullzer With Nextcloud 15 we will support multiple share links. This PR already implements everything you need to start implementing it on the client side. Just in case you are looking for something to do 😉

Creating links works the same as before. There is just the additional parameter "label" you can use to create/update link shares so that the user can give the share link names to remember which link was used for what.

[marinofaggiana]

ToDo added :-)

[jancborchardt]

I’d suggest to split this up to prevent it from becoming too big of a pull request:

API stuff:

• Allow to create multiple share links (API level)
• Get multiple share links (API level)
• allow to give share links unique names (API level)
• allow to change unique name of a share (API level)

Basic interface stuff:

• Allow to create multiple share links (web ui)
• Show multiple share links (web ui)

Future interface stuff that is optional:

• allow to give share links unique names (web ui)
• allow to change unique name of a share (web ui)

Especially since you already mentioned the possible conflicts with #11537 (which is quite short so shouldn’t really conflict a lot.)

[jancborchardt]

Just had a short call with @skjnldsv, and this is the spec now:

1. The default share list has one entry in it called 🔗 Share link as usual. On the right there’s a ➕ icon.

   • We have no checkbox anymore. A link either exists or not.

2. Clicking the whole row (not only the ➕) converts the entry into an active link

   • Automatically copies it to clipboard, with a tooltip as feedback "Link copied".
   • By default with read-only permissions (or edit? what do you think?)
   • It also replaces the ➕ icon with 📋 Copy link and 🞄🞄🞄 buttons.
   • Do we want to automatically open the 🞄🞄🞄 menu here too? (Maybe at least for the first link so it kind of shows people the options?)

3. Clicking the 🞄🞄🞄 button reveals the menu we know with the adjustment options.

   • Additionally it will have an entry called ➕ Add another link (feel free to suggest better/more succinct wording)
   • Tapping that entry will create another entry below it, basically same as step 2 above, automatically activating it and copying etc.

That’s that for now. Did I forget anything @skjnldsv?
In the future we can also have renaming of links, but for now it will just be "Share link", "Share link 2", "Share link 3" etc. Or ideally "Share link (read-only)" and "Share link 2 (read-only)" and "Share link (editable)" and "Share link (password-protected)".

[skjnldsv]

Should be finished today!
@jancborchardt @nextcloud/designers Can we try to find another saying for "Share link" I'm always finding this confusing as it looks like an action and not a statement :)

Can you start a review now?
That would increase my response time to fixes to day for the feature freeze :)

Basically the only thing left is the label handling! How should we do that?

1. Add an edit button?
2. In the popovermenu?

[jancborchardt]

Just beginning to test this! :) First feedback:

• The ➕ icon is not keyboard-accessible, no highlight on focus
• Ideally the whole row should be clickable, not just the ➕
• Not sure it’s screenreader-accessible right now with the "title" on the icon. But it would be when the whole row is the action.

[jancborchardt]

Made the background of the share link primary color instead of bland grey. This is in line with the change in the Talk app at nextcloud/spreed#1274

[skjnldsv]

Made the background of the share link primary color instead of bland grey. This is in line with the change in the Talk app at nextcloud/spreed#1274

I was afraid it would be too much, but it is spot on!! 👍

[danxuliu]

Fixed

Not so fast; I have some complaints ;-)

[skjnldsv]

@danxuliu be quick!
I want to get this in today! And don't use this as an excuse to merge your pr before mine :p

Fixed :D

[danxuliu]

Fixed :D

Almost :-P I will send a final fix.

[skjnldsv]

Failure unrelated: sh: 1: kill: No such process https://drone.nextcloud.com/nextcloud/server/12248/283

[skjnldsv]

Almost :-P I will send a final fix.

Ahaha! Okay :)
Thanks a lot for your help @danxuliu 🤗

[danxuliu]

Rejoice; finally, the nitpicker is reasonably satisfied 👍

I hope Drone is too... :-P

[MorrisJobke]

🎉 I will merge once drone has done it's job 🎉

[lopezio]

Future interface stuff that is optional:

• allow to give share links unique names (web ui)
• allow to change unique name of a share (web ui)

@schiessle @jancborchardt any progress on these points..? I think they're fundamental to make the multiple linking functionality usable.. with some kind of distinction between the shared links it would be possible to explicitely delete or re-share links based on a target public / individual..

Best Regards!