Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update strengthify to be able to set a nonce #11592

Merged
merged 2 commits into from
Oct 3, 2018
Merged

Update strengthify to be able to set a nonce #11592

merged 2 commits into from
Oct 3, 2018

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Oct 3, 2018 •
edited
Loading

  • actually set the correct nonce (see second commit)

For #11028

cc @rullzer

@MorrisJobke MorrisJobke added the 2. developing Work in progress label Oct 3, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Oct 3, 2018
MorrisJobke
MorrisJobke commented Oct 3, 2018
View reviewed changes
core/js/setup.js Outdated
@@ -123,6 +123,7 @@ $(document).ready(function() {
t('core', 'Strong password')
],
drawTitles: true,
nonce: 'TODO',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using window.btoa(OC.requestToken) didn't worked for me - at least not the same nonce was created.

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 3, 2018
@MorrisJobke MorrisJobke force-pushed the feature/noid/update-strengthify branch from 2382ba6 to c8e617b Compare October 3, 2018 15:05
@MorrisJobke
Copy link
Member Author

Tested, works and rebased 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2018
@rullzer rullzer merged commit f4387ed into master Oct 3, 2018
@rullzer rullzer deleted the feature/noid/update-strengthify branch October 3, 2018 16:40
@snyk-bot snyk-bot mentioned this pull request Jul 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@rullzer rullzer

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @rullzer @ChristophWurst