Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use main text color for editable divs and text areas #10925

Merged

Conversation

danxuliu
Copy link
Member

As discussed with @jancborchardt; no idea of what to do with other types of text areas like one-line input fields.

Before:
editable-div-color-before

After:
editable-div-color-after

@nextcloud/designers

@danxuliu danxuliu added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 29, 2018
@danxuliu danxuliu added this to the Nextcloud 14 milestone Aug 29, 2018
@juliusknorr
Copy link
Member

CI failure seems unrelated, probably an timeout when sending the request to the app store. https://drone.nextcloud.com/nextcloud/server/9990/257

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 30, 2018
@MorrisJobke MorrisJobke merged commit df7dc9c into master Aug 30, 2018
@MorrisJobke MorrisJobke deleted the use-main-text-color-for-editable-divs-and-text-areas branch August 30, 2018 18:59
@MorrisJobke MorrisJobke mentioned this pull request Aug 30, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants