Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log entries that are hidden during file listing #10697

Merged
merged 1 commit into from
Aug 20, 2018
Merged

log entries that are hidden during file listing #10697

merged 1 commit into from
Aug 20, 2018

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman [email protected]

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 15, 2018
@icewind1991 icewind1991 added this to the Nextcloud 14 milestone Aug 15, 2018
@icewind1991 icewind1991 mentioned this pull request Aug 15, 2018
Merged
blizzz
blizzz reviewed Aug 15, 2018
View reviewed changes
apps/files_external/lib/Lib/Storage/SMB.php Outdated
@@ -174,15 +183,18 @@ protected function getFolderContents($path) {
}
return array_filter($files, function (IFileInfo $file) {
try {
$this->logger->debug('hiding hidden file ' . $file->getName());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't the state depend on the return value of the following method?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

🙈

rullzer
rullzer approved these changes Aug 16, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me 🐘

@MorrisJobke MorrisJobke merged commit 1c13e78 into master Aug 20, 2018
@MorrisJobke MorrisJobke deleted the smb-log-removed-entries branch August 20, 2018 12:48
@rullzer rullzer mentioned this pull request Aug 22, 2018
Closed
3 tasks
@MorrisJobke MorrisJobke mentioned this pull request Aug 24, 2018
Merged
@skjnldsv
Copy link
Member

skjnldsv commented May 13, 2019 •
edited
Loading

@icewind1991 any reason we decide not to show hidden files?
We have a fix request on this :)

@icewind1991
Copy link
Member Author

because showing them would cause inconsistent views between NC and mounting the share in windows and we don't have proper hidden file handling

@skjnldsv
Copy link
Member

skjnldsv commented May 20, 2019 •
edited
Loading

we don't have proper hidden file handling

What do you mean by that?

We have the show/hide hidden files option in nextcloud, so it's also inconsistent between any smb mount and what is displayed on nextcloud. 🤔
We received feedback for this issue :)

@icewind1991
Copy link
Member Author

that only deals with files starting with ., there is no tracking of hiden state in the backend

@skjnldsv
Copy link
Member

Exactly, and dot files are set as hidden in samba.
So they do not appear.

@skjnldsv
Copy link
Member 

smb: \> ls
  .                                   D        0  Mon May 20 23:22:09 2019
  ..                                  D        0  Mon May 20 23:21:40 2019
  .test                              DH        0  Mon May 20 23:22:09 2019

@icewind1991
Copy link
Member Author

that's samba, with windows smb servers it's different

@skjnldsv
Copy link
Member

@icewind1991 okay, though this is an issue.
How do we handle this. Do you want me to create an issue?

@icewind1991
Copy link
Member Author

icewind1991 commented May 20, 2019 •
edited
Loading

I can add an option to show hidden items,

please create an issue for tracking

@skjnldsv skjnldsv mentioned this pull request May 21, 2019
Closed
@skjnldsv
Copy link
Member

Awesome @icewind1991 :)
see #15644

I owe you a beer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz left review comments

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
5 participants
@icewind1991 @skjnldsv @rullzer @MorrisJobke @blizzz