Fix duplicate inserts in the 2fa provider registry DAO #10462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added
bug
3. to review
2 tasks
rullzer
approved these changes
Jul 31, 2018
1 task
nickvergessen
approved these changes
Jul 31, 2018
ChristophWurst
added
4. to release
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the condition of setting the enabled/disabled state of a specific user-provider tuple more than once. I forgot to handle this in #9632.
cc DB pros @nickvergessen @rullzer. Is this the correct way to do an
UPSERTwith our query builder? Does the isolation level of our supported DBs guarantee that this is conflict free now?Discovered while making the TOTP app ready for Nextcloud 14 nextcloud/twofactor_totp#263.