Theming: Add logo and background to ThemingDefaults #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
theming-extend-defaults
branch
12 times, most recently
from
7e03063
to
867efcc
Compare
juliusknorr
force-pushed
the
theming-extend-defaults
branch
from
867efcc
to
80fe499
Compare
|
Ok, I've tried to figure out why the tests of #770 are failing. This PR contains the set of backend changes for the theming app that I think introduce the failing tests. @icewind1991 it would be really great if you could have a look. |
|
cc @nickvergessen as you mentioned something about the loading order in #770. |
|
Had a quick look, and we can fix this by using the lazy root, but well that is not as clean as it should be. But will push this never the less now. |
juliusknorr
added
3. to review
|
@nickvergessen Awesome! Thanks for the cleanup as well. Ready for review now. I'll create a new PR for the rest of #770 and after merge we also continue with #771 and #840. |
|
cc @schiessle @LukasReschke for review |
5 tasks
|
👍 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logo and background to the ThemingDefaults class. This allows further code in the theming app to query the current logo/background image url.