-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "X-Frame-Options" HTTP header is not set to "SAMEORIGIN". #8550
Comments
This should not be set in the web server, because we also set it in PHP - see #8207 for the full discussion about detecting this. As of now you should just remove it from the web server config and all should be fine. We are looking into detecting if it is set by the web server and then disable the PHP code for this. |
Closing as duplicate of #8207 |
Hello,
If i remove it from the apache config, then it doesn't show in Chrome developer consonsole and scan.nextcloud.com fails on the X-Frame-Options options.
So if the solution is to remove it from apache/webserver config, i need to create a new bug, because the header isnit added by nextcloud itself.
Lennard
Van: "Morris Jobke" <[email protected]>
Aan: "nextcloud/server" <[email protected]>
Cc: "Lennard Bakker" <[email protected]>, "Author" <[email protected]>
Verzonden: Dinsdag 27 februari 2018 09:49:59
Onderwerp: Re: [nextcloud/server] The "X-Frame-Options" HTTP header is not set to "SAMEORIGIN". (#8550)
Configure apache to have 'X-Frame-Options: SAMEORIGIN' set as header
This should not be set in the web server, because we also set it in PHP - see [ #8207 | #8207 ] for the full discussion about detecting this. As of now you should just remove it from the web server config and all should be fine. We are looking into detecting if it is set by the web server and then disable the PHP code for this.
—
You are receiving this because you authored the thread.
Reply to this email directly, [ #8550 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AKwjf1QwbXzWOJZ1HeBeth6Rl1EoZtmoks5tY8G3gaJpZM4STxKi | mute the thread ] .
|
It seems like modHeadersAvailable is not recognized for the X-Frame-Options header. Deactivating it in the server's settings, let's all kinds of header errors pop up again. Reactivating it again and the errors go away except for the X-Frame-Options problem. Also the header is in the response of the server, but it's still shown as a problem on the scan.nextcloud.com website. Which is weird. I know for a fact that my webserver always servers its headers... I guess that's caused by the header showing up multiple times? |
If the header is defined by nginx.conf remove it. |
@danielkesselberg been there. done that. doesn't change a thing. |
Hmm. We usually use the forum for configuration issues. It sounds like that somehow. If you think this is a software issue I would like to ask you to open a new issue because this one is closed. Thank you! |
Nextcloud 15.0.2
It did not change anything??? |
Mine is Nginx, and I am running NC 14, the same reminder appeared recently while it didn't for a long time since I upgraded to NC 14. My Nginx ver is 1.14.2 |
See #8207 for more details and possible workarounds. server/lib/private/legacy/response.php Line 97 in 554c78c
|
Steps to reproduce
Expected behaviour
No warning message about X-Frame-Options
Actual behaviour
Admin page will give X-Frame-Options error: "The "X-Frame-Options" HTTP header is not set to "SAMEORIGIN". This is a potential security or privacy risk, as it is recommended to adjust this setting accordingly."
Server configuration
**Operating system: CentOS Linux release 7.4.1708 (Core)
**Web server: Server version: Apache/2.4.29 (Unix)
**Database: mysql Ver 15.1 Distrib 5.5.41-MariaDB, for Linux (x86_64) using readline 5.1
**PHP version: PHP 7.1.14 (cli) (built: Feb 3 2018 09:42:33) ( NTS )
**Nextcloud version: 13.0.0
**Updated from an older Nextcloud/ownCloud or fresh install: update from older version, from 11 up to current.
**Where did you install Nextcloud from: https://nextcloud.com/install/
Signing status:
Signing status
Insert your browser log here, this could for example include:
HTTP/1.1 200 OK
Date: Mon, 26 Feb 2018 18:51:22 GMT
Server: Apache/2
Strict-Transport-Security: max-age=31536000; includeSubDomains
Upgrade: h2,h2c
Connection: Upgrade, Keep-Alive
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-cache, no-store, must-revalidate
Pragma: no-cache
Content-Security-Policy: default-src 'none';base-uri 'none';manifest-src 'self';script-src 'nonce-ZEJsL2JITVdsWVdRNW56WVpjb202dHlEdzBKUWNFZXdTRVN2a3phVGJiST06SlZZTkdrQlY0Ynp6Z1NpMUxvaEsyWmZSbFRZWFBpVGFJQ3VjOFZMd1h0Yz0=' 'unsafe-eval';style-src 'self' 'unsafe-inline';img-src 'self' data: blob:;font-src 'self';connect-src 'self';media-src 'self'
X-Frame-Options: SAMEORIGIN
Vary: Accept-Encoding,User-Agent
Content-Encoding: gzip
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
X-Robots-Tag: none
X-Download-Options: noopen
X-Permitted-Cross-Domain-Policies: none
Content-Length: 6095
Keep-Alive: timeout=2, max=100
Content-Type: text/html; charset=UTF-8
The text was updated successfully, but these errors were encountered: