-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add occ commands to pregenerate CSS and JS files #7984
Comments
So we could have a fix to give to users who have a broken setup? |
Makes sense to have, basically this is what is left in #6587. |
We should also fore rebuild during upgrade when implementing this. |
PR to clear the caches during update / occ maintenance:repair is in #7984 |
@juliushaertl Something for the polishing phase or should we just drop this in favor of the idea to not generate it during runtime, but during build time? |
So JS will be generated at build time for all the vue apps. That would cover most of it at some point. |
We could do that for core scss/js but we cannot easily determine what files apps use for their styles or scripts and need to do it at runtime. At least with our current API. |
Most likely nothing for 14 -> moving to 15. |
is this still being worked on? Integrating this into occ maintenance:repair is overkill for us as it puts the instance into maintenance mode when we just want to regenerate CSS and JS files |
I guess nobody is working on this. We also will not have the dynamic SCSS generation on the instances itself that long anymore. It is planned to be moved into the build process once we can remove the IE compatibility, which we will deprecated in Nextcloud 20 and most likely 2-3 releases later. Then we can use CSS variables and this whole problem is not anymore. |
SCSS cacher has been removed and JS+CSS are compiled in the package now |
Just so it doesn't have to happen on demand.
As an added bonus we could add a '--rebuild' flag or something. So that if people somehow mess up their files in the appdata dir. That we just regenerate everything.
@skjnldsv does this make sense to you?
The text was updated successfully, but these errors were encountered: