-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File view: Double click and right click #5
Comments
I think that could cause browser or os specific problems. Especially on mobile devices. I don't know whether we should introduce right- or double-click actions and menus 😕 cc @nextcloud/designers |
I've thought of that. These users can still use the "three-dot-menu", can't they? I wouldn't remove the current menus. |
Sure you can maintain a mouse and a touch version where in the mouse version everything is delegated to a menu opened by a right click while the touch version has separate buttons. Turns out maintaining two different interaction models is just very, very cumbersome. It's much easier to find the common ground and make it work well for both platforms. |
Wouldn't it be possible to save all menu entries in one database and then specify where every entry should appear? |
No need to save it in the database at all ;) Building, testing and maintaining the UI while keeping both designs consistent is the real challenge |
I just thought of the three-dot-menu to be displayed at the position of the mouse (same css class etc., but with all entries). I'm sorry, I think I'm too dumb to understand the problem here. |
As @Mar1u5 and @BernhardPosselt already mentioned, there are severe maintenance problems with it. Apart from that, double-click is used nowhere in browsers and usually is used for marking text, so it will likely lead to issues. Also, neither double-click nor right-click is easily discoverable, so we should not use it. |
Aah ok so I mean the right-cick thing we might be able to do, displaying the 3-dot-menu at the position of the cursor. @BernhardPosselt @MorrisJobke @Henni do you think this is doable? |
Won't this still break the context menu as in prevent you from copy text? |
But in the list there’s nothing to copy. If you really want to copy the filename, you can rename and then copy. Marking by dragging is not possible anyway because of drag&drop kicking in. |
Something new here? I think the right click menu replace the standard browser right click menu, I'm right? |
Adding some activity to this as I'd like to see right-click menus implemented 👍 |
This sounds like a good Javascript starter issue.
@jasonbayton @Bullnados @maprambo please let your programmer friends know of this issue if you want to push development. :) We are an open source project and everyone can contribute. |
After much deliberation I think it’s best to not even make right-click any part of Nextcloud. For a few simple reasons:
It’s pretty much impossible to make sure all apps follow suit on this. For the little gain this gives us it’s not worth the risk at all. |
# This is the 1st commit message: Patch from PR 24574 to view.js Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#2: Patch from PR 24574 to lib/Connection.php Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#3: Patch from PR 24574 to lib/Wizard.php Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#4: Patch from PR 24574 to lib/LDAP.php (manually) Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#5: Added a function usesLdapi() in Configuration.php and referenced that function throughout the PR Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#6: Removed the questions I added in comments - https://github.com/nextcloud/server/pull/24574/files#r825732903 Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#7: Changed the test as requested - https://github.com/nextcloud/server/pull/24574/files#r825726282 Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#8: Changing return type from bool to int Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#9: Changing return type of usesLdapi() to bool and adapting references Signed-off-by: Vincent Van Houtte <[email protected]>
fixes this error caused when system has usernames that are purely numeric. An unhandled exception has been thrown: Error: Object of class OCA\User_LDAP\User\User could not be converted to string in /var/www/nextcloud/apps/user_ldap/lib/User_LDAP.php:312 Stack trace: #0 [internal function]: OCA\User_LDAP\User_LDAP->userExistsOnLDAP() nextcloud#1 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(126): call_user_func_array() nextcloud#2 /var/www/nextcloud/apps/user_ldap/lib/Proxy.php(140): OCA\User_LDAP\User_Proxy->walkBackends() nextcloud#3 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(262): OCA\User_LDAP\Proxy->handleRequest() nextcloud#4 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(239): OCA\User_LDAP\User_Proxy->userExistsOnLDAP() nextcloud#5 /var/www/nextcloud/lib/private/User/Manager.php(168): OCA\User_LDAP\User_Proxy->userExists() nextcloud#6 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(399): OC\User\Manager->get() nextcloud#7 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(226): OCA\Files_FullTextSearch\Service\FilesService->initFileSystems() nextcloud#8 /var/www/nextcloud/apps/files_fulltextsearch/lib/Provider/FilesProvider.php(246): OCA\Files_FullTextSearch\Service\FilesService->getChunksFromUser() nextcloud#9 /var/www/nextcloud/apps/fulltextsearch/lib/Service/IndexService.php(174): OCA\Files_FullTextSearch\Provider\FilesProvider->generateChunks() nextcloud#10 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(403): OCA\FullTextSearch\Service\IndexService->indexProviderContentFromUser() nextcloud#11 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(280): OCA\FullTextSearch\Command\Index->indexProvider() nextcloud#12 /var/www/nextcloud/3rdparty/symfony/console/Command/Command.php(298): OCA\FullTextSearch\Command\Index->execute() nextcloud#13 /var/www/nextcloud/core/Command/Base.php(177): Symfony\Component\Console\Command\Command->run() nextcloud#14 /var/www/nextcloud/3rdparty/symfony/console/Application.php(1040): OC\Core\Command\Base->run() nextcloud#15 /var/www/nextcloud/3rdparty/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand() nextcloud#16 /var/www/nextcloud/3rdparty/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun() nextcloud#17 /var/www/nextcloud/lib/private/Console/Application.php(206): Symfony\Component\Console\Application->run() nextcloud#18 /var/www/nextcloud/console.php(100): OC\Console\Application->run() nextcloud#19 /var/www/nextcloud/occ(11): require_once('...') nextcloud#20 {main}roopico /var/www/nextcloud/apps/user_ldap/lib/User/OfflineUser.phparch:index Signed-off-by: Alexie Papanicolaou <[email protected]>
Afaik since ownCloud 8.2 there is a side panel with extra information. Since then, friends of mine had problems opening files and folder in the web interface. In most native file browsers you have to double click to open a file or folder - why not doing this in Nextcloud, too?
Another thing is that all the options for sharing, renaming, downloading and so on should also be accessible via right click.
Both these small changes would improve the navigation and make Nextcloud feel more native.
The text was updated successfully, but these errors were encountered: