-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write Nextcloud groups as CATEGORIES of system address book contacts #38432
Comments
Users do see their own groups at the personal settings / profile settings page (bottom left). If other users should see this information is to be researched or defined. Right now you can find out the members of a group by adding them to a share or a Talk room. But you can't do the inverse of getting the groups of a user. |
…ntacts Closes #38432 Signed-off-by: Thomas Citharel <[email protected]>
…ntacts Closes #38432 Signed-off-by: Thomas Citharel <[email protected]>
…ntacts Closes #38432 Signed-off-by: Thomas Citharel <[email protected]>
…ntacts Closes #38432 Signed-off-by: Thomas Citharel <[email protected]>
…ntacts And move event listeners related to SyncService to proper ones Note: Changes to user system addressbook cards are now always done in a QueuedJob Closes #38432 Signed-off-by: Thomas Citharel <[email protected]>
…ntacts And move event listeners related to SyncService to proper ones Note: Changes to user system addressbook cards are now always done in a QueuedJob Closes #38432 Signed-off-by: Thomas Citharel <[email protected]>
@AndyScherzinger @DaphneMuller @jancborchardt @juliushaertl @nickvergessen @sorbaugh @tobiasKaminsky please excuse the ping-all but this change is worked on in #40997 and I believe we should have platform-wide consent about the exposure of group membership of other users. Right now you can only see your own groups in the personal settings. You do not see who's member of the admins or any other Nextcloud groups. If groups are stored with system address book contacts, this information will be visible to all other users for the first time. Do we want that? |
Admins is like the only exception because it's exposed by various apps, including the default shipped data_request But yeah, not sure we should leak all groups. |
I am sure that we should not do this, as this is sensitive data. |
…ntacts And move event listeners related to SyncService to proper ones Note: Changes to user system addressbook cards are now always done in a QueuedJob Closes #38432 Signed-off-by: Thomas Citharel <[email protected]>
…ntacts And move event listeners related to SyncService to proper ones Note: Changes to user system addressbook cards are now always done in a QueuedJob Closes #38432 Signed-off-by: Thomas Citharel <[email protected]>
I've disabled the feature by default through an appconfig, and there's also other appconfig options to include or exclude groups that will be exposed. What do you think? |
I think that is a good compromise. Groups aren't exposed by default and if admins are okay with exposure they can configure it explicitly. In the long run groups could have a visibility setting similar to user profile properties. Admins could use them to set the visibility scope of a group:
|
I would even like a "hidden" visibility scope where only admins see the group but not "normal members" |
How to use GitHub
Is your feature request related to a problem? Please describe.
Nextcloud 27 exposes the system address book with read-only contacts for all system users. It's common to have Nextcloud groups for departments, teams and projects.
Describe the solution you'd like
Add a CATEGORIES property to the system contacts based on the display names of a user's Nextcloud groups.
This requires users to be allowed to see other user's groups.
Describe alternatives you've considered
N/a
Additional context
#19575
The text was updated successfully, but these errors were encountered: