We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refers to #3069
For all parameters default values should be set and the same default value should be used for all appearances in the source code.
Not all of the parameters are set to a fixed default value, nor have they the same default value assigned in the source code.
As far as I understood the default value of the parameter mail_smtpmode should be sendmail but other values have been assigned in the source code:
mail_smtpmode
+ getSystemValue('mail_smtpmode', 'sendmail') # ok, default value !! - /var/www/htdocs/nextcloud/lib/private/Mail/Mailer.php:203 + getSystemValue('mail_smtpmode', 'php') # <<< wrong value, should be 'sendmail' - /var/www/htdocs/nextcloud/lib/private/Mail/Mailer.php:156 + getSystemValue('mail_smtpmode', '') # <<< wrong value, should be 'sendmail' - /var/www/htdocs/nextcloud/lib/private/Settings/Admin/Additional.php:58
OS: Linux 3.2.82 Web server: Apache2 2.4.25 Database: MariaDB 5.5.53 PHP version: 5.6.29 Nextcloud version: 11.0.0
Browser: Mozilla Firefox 50.1.0 Operating system: Windows 7
The text was updated successfully, but these errors were encountered:
Fix default of mail_smtpmode - fixes #3102
12e3b35
Signed-off-by: Morris Jobke <[email protected]>
Fix is in #3177
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
refers to #3069
Expected behavior
For all parameters default values should be set and the same default value should be used for all appearances in the source code.
Current behavior
Not all of the parameters are set to a fixed default value, nor have they the same default value assigned in the source code.
As far as I understood the default value of the parameter
mail_smtpmode
should be sendmail but other values have been assigned in the source code:Steps to reproduce
Environment
Server Configuration
OS: Linux 3.2.82
Web server: Apache2 2.4.25
Database: MariaDB 5.5.53
PHP version: 5.6.29
Nextcloud version: 11.0.0
Client Configuration
Browser: Mozilla Firefox 50.1.0
Operating system: Windows 7
The text was updated successfully, but these errors were encountered: