Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different default values are used for parameter 'mail_smtpmode` #3102

Closed
j-ed opened this issue Jan 16, 2017 · 1 comment · Fixed by #3177
Closed

different default values are used for parameter 'mail_smtpmode` #3102

j-ed opened this issue Jan 16, 2017 · 1 comment · Fixed by #3177
Labels
3. to review Waiting for reviews

Comments

@j-ed
Copy link
Contributor

j-ed commented Jan 16, 2017

refers to #3069

Expected behavior

For all parameters default values should be set and the same default value should be used for all appearances in the source code.

Current behavior

Not all of the parameters are set to a fixed default value, nor have they the same default value assigned in the source code.

As far as I understood the default value of the parameter mail_smtpmode should be sendmail but other values have been assigned in the source code:

+ getSystemValue('mail_smtpmode', 'sendmail')       # ok, default value !!
- /var/www/htdocs/nextcloud/lib/private/Mail/Mailer.php:203

+ getSystemValue('mail_smtpmode', 'php')            # <<< wrong value, should be 'sendmail'
- /var/www/htdocs/nextcloud/lib/private/Mail/Mailer.php:156

+ getSystemValue('mail_smtpmode', '')               # <<< wrong value, should be 'sendmail'
- /var/www/htdocs/nextcloud/lib/private/Settings/Admin/Additional.php:58

Steps to reproduce

  1. search and compare the assigned values in the getSystemValue() call.

Environment

Server Configuration

OS: Linux 3.2.82
Web server: Apache2 2.4.25
Database: MariaDB 5.5.53
PHP version: 5.6.29
Nextcloud version: 11.0.0

Client Configuration

Browser: Mozilla Firefox 50.1.0
Operating system: Windows 7

MorrisJobke added a commit that referenced this issue Jan 20, 2017
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Jan 20, 2017
@MorrisJobke
Copy link
Member

Fix is in #3177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants