Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support iMip emails that don't link to server, for nextcloud servers on a private network #12156

Closed
brad2014 opened this issue Oct 31, 2018 · 5 comments

Comments

@brad2014
Copy link
Contributor

Feature request:

Support nextcloud servers that are on a private network (e.g. at home) which, for privacy/security are not accessible from the public internet:

Have a system configuration setting that tells the CalDAV IMip mail generator (and any other mail generator that sends mails to 3rd parties externally) to exclude URL's that refer to the server. For example, IMip mails have image icons (which should be bundled with the email), and accept/decline buttons (These can simply be suppressed from the emails when that global setting is turned on—clients will accept/decline via iMIP replies instead).

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #7622 (NextCloud Server Listener ), #11875 (Add support for sending the password for a link share by Nextcloud Talk), #2344 (Link to GitHub issue tracker is broken on Nextcloud support page), #2024 (http2 support in NextCloud), and #7928 (Deploy NextCloud Server on a Machine ).

georgehrke pushed a commit that referenced this issue Aug 1, 2019
Fix Issue #11230
Only present accept/decline button links in iMip mail for REQUEST, not CANCEL or others.

Fix Issue #12156
Implement config setting "dav.invitation_link_recipients", to control
which invitation recipients see accept/decline button links.  The
default, for public internet facing servers, is to always include
them.  For a server on a private intranet, this setting can be set
to the email addresses or email domains of users whose browsers can
access the nextcloud server referenced by those accept/decline
button links. It can also be set to "false" to exclude the links
from all requests.

Signed-off-by: Brad Rubenstein <[email protected]>
georgehrke pushed a commit that referenced this issue Aug 1, 2019
Fix Issue #11230
Only present accept/decline button links in iMip mail for REQUEST, not CANCEL or others.

Fix Issue #12156
Implement config setting "dav.invitation_link_recipients", to control
which invitation recipients see accept/decline button links.  The
default, for public internet facing servers, is to always include
them.  For a server on a private intranet, this setting can be set
to the email addresses or email domains of users whose browsers can
access the nextcloud server referenced by those accept/decline
button links. It can also be set to "false" to exclude the links
from all requests.

Signed-off-by: Brad Rubenstein <[email protected]>
@georgehrke
Copy link
Member

@brad2014 Was this solved in #12392? :)

@brad2014
Copy link
Contributor Author

Yes, thank you! I'm not clear what release the fix #12392 is included in. Are you asking me to close this issue? (I'm happy to do so; I wasn't sure if that was to be done by me or by the person who merged the PR).

@georgehrke
Copy link
Member

This will be included in Nextcloud 17, which will be released shortly. :)

Let me go ahead and close the two issues then.

@georgehrke
Copy link
Member

Fixed in #12392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants