Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate dropping php7.0 support #12021

Closed
1 task done
ChristophWurst opened this issue Oct 24, 2018 · 26 comments
Closed
1 task done

Evaluate dropping php7.0 support #12021

ChristophWurst opened this issue Oct 24, 2018 · 26 comments

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Oct 24, 2018

According to https://secure.php.net/supported-versions.php, php7.0 EOL's soon. We should evaluate when to increase the minimum supported version.

cc @blizzz @daita @danxuliu @georgehrke @icewind1991 @juliushaertl @MorrisJobke @nickvergessen @rullzer @schiessle @skjnldsv

@rullzer
Copy link
Member

rullzer commented Oct 24, 2018

Ubuntu 18.04 is php7.2 if I'm not mistaken

@georgehrke
Copy link
Member

Debian Stretch is 7.0: https://packages.debian.org/stretch/php

@rullzer
Copy link
Member

rullzer commented Oct 24, 2018

Debian will ship 7.2 in Buster: https://tracker.debian.org/pkg/php7.2
Which is scheduled for 2019

@rullzer
Copy link
Member

rullzer commented Oct 24, 2018

RHEL has a software collections for php7.1: https://www.softwarecollections.org/en/scls/rhscl/rh-php71/

@rullzer
Copy link
Member

rullzer commented Oct 24, 2018

SLES15 seems to have 7.2: https://build.opensuse.org/package/show/Apache:Modules/php7

@icewind1991
Copy link
Member

besides it getting eol, are there any 7.1 features that people are waiting to make us of?

@rullzer
Copy link
Member

rullzer commented Oct 24, 2018

More and more of our dependencies are dropping 7.0 support. So not upgrading blocks us from updating those.

@icewind1991
Copy link
Member

fair enough

@danopz
Copy link

danopz commented Oct 25, 2018

besides it getting eol, are there any 7.1 features that people are waiting to make us of?

Nullable and void return types e.g.

@tflidd
Copy link
Contributor

tflidd commented Oct 25, 2018

It's probably a good idea to be able to run the current Nextcloud version on a current Debian setup. Debian buster comes out in spring 2019. So until end of 2019 (to give some time for migration), it would be great to have php7.0 support so NC can be used with debian stretch.

The current support cycle for a Nextcloud version seems to be around 1 year. So for NC 15 it would be great to still have php 7.0 support.

From the survey tool, do you get any feedback which php versions are used?

@rullzer
Copy link
Member

rullzer commented Oct 25, 2018

15 will support php7, 7.1 and 7.2
This is about future NC versions

@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 25, 2018

Current stats:

Version Precentage
PHP 5.4 >1 %
PHP 5.5 >1 %
PHP 5.6 8 %
PHP 7.0 48 %
PHP 7.1 15 %
PHP 7.2 29 %
PHP 7.3 >1 %

@blizzz
Copy link
Member

blizzz commented Oct 25, 2018

If Debian abandons 7.0 in 2019 only (when exactly?), we should perhaps keep it supported into 2020.

@georgehrke
Copy link
Member

If Debian abandons 7.0 in 2019 only (when exactly?), we should perhaps keep it supported into 2020.

But as @rullzer said, Nextcloud 15 is definitely gonna support PHP 7.0.
Given the currently planned release date and our "2 releases + 12 weeks" rule, EOL is gonna be sometime in 2020.

@blizzz
Copy link
Member

blizzz commented Oct 26, 2018

True… well, depends how much pressure we want to put on those admins. As, I guess Debian, will support this for a long time on that release. They have their full freeze planned for March, which is still far away from a release. This it depends on our future release plannings, but maybe it is reasonable to keep the support until Debian releases.

@rullzer
Copy link
Member

rullzer commented Oct 26, 2018

IF we decide to still support php7.0 after it is EOL I do vote for adding a notification to the admin settings. Because if there are significant security issues with it php won't fix them anymore

@MorrisJobke
Copy link
Member

IF we decide to still support php7.0 after it is EOL I do vote for adding a notification to the admin settings. Because if there are significant security issues with it php won't fix them anymore

I'm totally fine with adding a warning to all releases right now to get awareness to the admins.

@rullzer
Copy link
Member

rullzer commented Oct 26, 2018

I'm totally fine with adding a warning to all releases right now to get awareness to the admins.

Actually not a bad idea. As even users on 13 on php7.0 end of december will run defacto EOL software

@ChristophWurst
Copy link
Member Author

How do we proceed for 16?

@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Nov 30, 2018
@ChristophWurst
Copy link
Member Author

Just ran into an issue: Mariadb 10.2 (which is used on many Docker images and other installations) is not fully supported by doctrine/dbal v2.5 (which we currently use). v2.6 and later (:warning: actually v2.8 is the oldest maintained version) require php7.1 though.

Found at nextcloud/twofactor_admin#20 (comment).

@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 2, 2019

Current stats:

Version Precentage (Change to end of October)
PHP 5.4 <1 %
PHP 5.5 <1 %
PHP 5.6 6 % (-2)
PHP 7.0 43 % (-5)
PHP 7.1 14 % (-1)
PHP 7.2 35 % (+6)
PHP 7.3 2 % (+2)

@rullzer
Copy link
Member

rullzer commented Jan 3, 2019

#13122

NC16 will be >=PHP7.1

@MorrisJobke
Copy link
Member

Added to #12915

@TP75
Copy link

TP75 commented Apr 29, 2019

Thank you all for the good work and the assessment. However, just as a note on:

@MorrisJobke :
Please be aware in both your current stats PHP tables the comparicon of Percentage should be "< 1%" for certain values and not "> 1%" as stated. The meaning should be "lower 1%" if you check the numbers and according sums appropriately.
This may be a minor slip but is a matter of correctness and could get importance while coding.

@e-alfred
Copy link

@MorrisJobke Are those stats publicly available somwhere?

@MorrisJobke
Copy link
Member

@MorrisJobke Are those stats publicly available somwhere?

Nope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants