Merge pull request #28494 from nextcloud/backport/28481/stable22

[stable22] Hash cache key
nextcloud · Aug 18, 2021 · f3f1c82 · f3f1c82
2 parents e1d9a45 + 79b5421
commit f3f1c82
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/private/User/Manager.php b/lib/private/User/Manager.php
@@ -158,7 +158,7 @@ public function get($uid) {
 			return $this->cachedUsers[$uid];
 		}
 
-		$cachedBackend = $this->cache->get($uid);
+		$cachedBackend = $this->cache->get(sha1($uid));
 		if ($cachedBackend !== null && isset($this->backends[$cachedBackend])) {
 			// Cache has the info of the user backend already, so ask that one directly
 			$backend = $this->backends[$cachedBackend];
@@ -174,7 +174,8 @@ public function get($uid) {
 			}
 
 			if ($backend->userExists($uid)) {
-				$this->cache->set($uid, $i, 300);
+				// Hash $uid to ensure that only valid characters are used for the cache key
+				$this->cache->set(sha1($uid), $i, 300);
 				return $this->getUserObject($uid, $backend);
 			}
 		}