Do not pass '.' along as path

Fixes #11637 When writing a file to the root of a shared storage we have to obtain creatable information on the root of the share. However getting the dirname of the path then results in '.'. Passing this along potentially breaks. For example objectstores do not have the same hierachy as a normal fs. So the file '.' doesn't mean anything in that context. Signed-off-by: Roeland Jago Douma <[email protected]>
nextcloud · Oct 11, 2018 · e1b7950 · e1b7950
1 parent fe45db6
commit e1b7950
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/apps/files_sharing/lib/SharedStorage.php b/apps/files_sharing/lib/SharedStorage.php
@@ -258,12 +258,16 @@ public function fopen($path, $mode) {
 				case 'xb':
 				case 'a':
 				case 'ab':
-					$creatable = $this->isCreatable(dirname($path));
+					$dirname = dirname($path);
+					if ($dirname === '.') {
+						$dirname = '';
+					}
+					$creatable = $this->isCreatable($dirname);
 					$updatable = $this->isUpdatable($path);
 					// if neither permissions given, no need to continue
 					if (!$creatable && !$updatable) {
 						if (pathinfo($path, PATHINFO_EXTENSION) === 'part') {
-							$updatable = $this->isUpdatable(dirname($path));
+							$updatable = $this->isUpdatable($dirname);
 						}
 
 						if (!$updatable) {